Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor ledger reported issues #107

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Fix minor ledger reported issues #107

merged 5 commits into from
Apr 23, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Apr 22, 2024 •
edited
Loading

Ledger report some small issues:

@spalmer25 spalmer25 self-assigned this Apr 22, 2024
@spalmer25 spalmer25 linked an issue Apr 22, 2024 that may be closed by this pull request
Minor issue reported by Ledger #106
Closed
5 tasks
@spalmer25 spalmer25 force-pushed the palmer@functori@fix-minor-ledger-reported-issues branch from ee64404 to 316208b Compare April 22, 2024 14:48
@spalmer25 spalmer25 changed the title Palmer@functori@fix minor ledger reported issues Fix minor ledger reported issues Apr 22, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@fix-minor-ledger-reported-issues branch 2 times, most recently from 5bc1ddc to 316208b Compare April 23, 2024 14:12
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 April 23, 2024 14:15
@spalmer25 spalmer25 marked this pull request as ready for review April 23, 2024 14:15
ajinkyaraj-23
ajinkyaraj-23 reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to check microtez to string conversion with a fractional microtez value with large trailing zeros. A value with no trailing zeros like 19.999999 tez.

@spalmer25
Copy link
Collaborator Author

Can we add a test to check microtez to string conversion with a fractional microtez value with large trailing zeros. A value with no trailing zeros like 19.999999 tez.

Done: Test: test the tz display

@spalmer25 spalmer25 force-pushed the palmer@functori@fix-minor-ledger-reported-issues branch from ef7e422 to 51dced4 Compare April 23, 2024 15:22
@ajinkyaraj-23 ajinkyaraj-23 self-requested a review April 23, 2024 15:36
ajinkyaraj-23
ajinkyaraj-23 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 15e21a2 into main Apr 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

Assignees

@spalmer25 spalmer25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor issue reported by Ledger
2 participants
@spalmer25 @ajinkyaraj-23